On Fri, 12 Sep 2025, Tiezhu Yang wrote: > On 2025/9/11 下午9:50, Miroslav Benes wrote: > > Hi, > > > > On Tue, 9 Sep 2025, Tiezhu Yang wrote: > > > >> Add config LIVEPATCH_DEBUG and define DEBUG if CONFIG_LIVEPATCH_DEBUG > >> is set, then pr_debug() can print a debug level message, it is a easy > >> way to get debug information without dynamic debugging. > > > > I do not have a strong opinion but is it really worth it? Configuring > > This is an alternative way, there are some similar usages: > > drivers/iommu/exynos-iommu.c: > #ifdef CONFIG_EXYNOS_IOMMU_DEBUG > #define DEBUG > #endif > > drivers/mtd/nand/raw/s3c2410.c: > #ifdef CONFIG_MTD_NAND_S3C2410_DEBUG > #define DEBUG > #endif > > drivers/usb/storage/usb.c: > #ifdef CONFIG_USB_STORAGE_DEBUG > #define DEBUG > #endif > > > dynamic debug is not difficult, it is more targetted (you can enable it > > just for a subset of functions in livepatch subsystem) and it can also be > > done on the command line. > > Yes, this is true. It is up to the maintainers to apply this patch > or not.
Right and I do not see the point to have it in the tree for the reasons above. Miroslav
