On Wed, May 28, 2025 at 7:51 PM Jesung Yang <y.j3m...@gmail.com> wrote: > > Remove `use core::ffi::c_void`, which shadows `kernel::ffi::c_void` > brought in via `use crate::prelude::*`, to maintain consistency and > centralize the abstraction. > > Since `kernel::ffi::c_void` is a straightforward re-export of > `core::ffi::c_void`, both are functionally equivalent. However, using > `kernel::ffi::c_void` improves consistency across the kernel's Rust code > and provides a unified reference point in case the definition ever needs > to change, even if such a change is unlikely. > > Reviewed-by: Benno Lossin <los...@kernel.org> > Signed-off-by: Jesung Yang <y.j3m...@gmail.com> > Link: > https://rust-for-linux.zulipchat.com/#narrow/channel/288089/topic/x/near/520452733
Looks good to me, thanks! If KUnit picks this next cycle: Acked-by: Miguel Ojeda <oj...@kernel.org> Otherwise, I am happy to take it too. Cheers, Miguel
