> > > > > /* > > > diff --git a/arch/x86/kernel/cpu/sgx/main.c > > b/arch/x86/kernel/cpu/sgx/main.c > > > index 2de01b379aa3..a018b01b8736 100644 > > > --- a/arch/x86/kernel/cpu/sgx/main.c > > > +++ b/arch/x86/kernel/cpu/sgx/main.c > > > @@ -917,6 +917,20 @@ int sgx_set_attribute(unsigned long > > *allowed_attributes, > > > } > > > EXPORT_SYMBOL_GPL(sgx_set_attribute); > > > > > > +/* Counter to count the active SGX users */ > > > +static atomic64_t sgx_usage_count; > > > + > > > +int sgx_inc_usage_count(void) > > > +{ > > > + atomic64_inc(&sgx_usage_count); > > > + return 0; > > > +} > > > > Maybe this was discussed but why this is not just a void-function? > > The last patch is cleaner if the prototype is already > returning int here. Also error unwinding takes this into account > right in this patch. Do you have objections to leave it as it is? > >
You can clarify this in the changelog of this patch (which I also suggested in v5).