On Fri, May 09, 2025 at 10:10:28AM -0700, Kees Cook wrote: > On Fri, May 09, 2025 at 02:54:11PM +0200, Joel Granados wrote: > > Move both sysrq ctl_table and supported sysrq_sysctl_handler helper > > function into drivers/tty/sysrq.c. Replaced the __do_proc_dointvec in > > helper function with do_proc_dointvec as the former is local to > > kernel/sysctl.c. > > nit: do_proc_dointvec_minmax Thx. I even added a small comment to the commit message to clarify: ``` Move both sysrq ctl_table and supported sysrq_sysctl_handler helper function into drivers/tty/sysrq.c. Replaced the __do_proc_dointvec in helper function with do_proc_dointvec_minmax as the former is local to kernel/sysctl.c. Here we use the minmax version of do_proc_dointvec because do_proc_dointvec is static and calling do_proc_dointvec_minmax with a NULL min and max is the same as calling do_proc_dointvec. ```
I'll also put a comment in the code to make sure that a min max is not added by mistake. Best -- Joel Granados
signature.asc
Description: PGP signature
