Il 19/03/25 15:25, Nícolas F. R. A. Prado ha scritto:
On Wed, Mar 19, 2025 at 08:16:37AM +0100, Krzysztof Kozlowski wrote:
On 18/03/2025 23:22, Nícolas F. R. A. Prado wrote:
Both MT8192 and MT8195 have an L1TCM memory, so it should be described
in reg, and therefore reg's minItems should be 3, as is already implicit
by reg-names. Override minItems to 3 for MT8192 and MT8195.

I think that was the original intention already, because reg-names are
expecting min 3 items. Basically you just correct the missing lower
constraint.

Yes, exactly, that's what I meant by "is already implicit by reg-names".


Nicolas, any way you can respin this patch so that we can get SCP for MT8188
in this merge window, please?

If you cannot do that, I can respin it on my own, no problem.

Thanks,
Angelo



Fixes: 6b55b1e2fd7f ("dt-bindings: remoteproc: mediatek: Support MT8195 dual-core 
SCP")
Signed-off-by: Nícolas F. R. A. Prado <nfrapr...@collabora.com>
---
  Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml | 1 +
  1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml 
b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
index 
adc6b3f36fde49eb3fa7ed3f08b0fa9e7f331162..ee33c233e44f3d51f0851b35697a24208c87f68a
 100644
--- a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
@@ -185,6 +185,7 @@ allOf:
      then:
        properties:
          reg:
+          minItems: 3
            maxItems: 3

maxItems can be dropped.

Sure, I can send a patch for that in the next version.

Thanks,
Nícolas



Reply via email to