On Thu, Feb 27, 2025 at 09:26:40AM -0800, Paul E. McKenney wrote: > On Thu, Feb 27, 2025 at 09:12:39AM -0800, Boqun Feng wrote: > > Hi Ulad, > > > > I put these three patches into next (and misc.2025.02.27a) for some > > testing, hopefully it all goes well and they can make it v6.15. > > > > A few tag changed below: > > > > On Thu, Feb 27, 2025 at 02:16:13PM +0100, Uladzislau Rezki (Sony) wrote: > > > Switch for using of get_state_synchronize_rcu_full() and > > > poll_state_synchronize_rcu_full() pair to debug a normal > > > synchronize_rcu() call. > > > > > > Just using "not" full APIs to identify if a grace period is > > > passed or not might lead to a false-positive kernel splat. > > > > > > It can happen, because get_state_synchronize_rcu() compresses > > > both normal and expedited states into one single unsigned long > > > value, so a poll_state_synchronize_rcu() can miss GP-completion > > > when synchronize_rcu()/synchronize_rcu_expedited() concurrently > > > run. > > > > > > To address this, switch to poll_state_synchronize_rcu_full() and > > > get_state_synchronize_rcu_full() APIs, which use separate variables > > > for expedited and normal states. > > > > > > Link: https://lore.kernel.org/lkml/Z5ikQeVmVdsWQrdD@pc636/T/ > > > > I switch this into "Closes:" per checkpatch. > > > > > Fixes: 988f569ae041 ("rcu: Reduce synchronize_rcu() latency") > > > Reported-by: cheung wall <zzqq0103....@gmail.com> > > > Signed-off-by: Uladzislau Rezki (Sony) <ure...@gmail.com> > > > > You seem to forget add Paul's Reviewed-by, so I add it in rcu/next. > > Would you or Paul double-check the Reviewed-by should be here? > > I am good with keeping my Reviewed-by tags. >
Thank you! Regards, Boqun > Thanx, Paul > [...]
