Use device lifecycle managed devm_rproc_add() helper function. This
helps prevent mistakes like deleting out of order in cleanup functions
and forgetting to delete on all error paths.

Signed-off-by: Beleswar Padhi <b-pa...@ti.com>
---
 drivers/remoteproc/ti_k3_r5_remoteproc.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/remoteproc/ti_k3_r5_remoteproc.c 
b/drivers/remoteproc/ti_k3_r5_remoteproc.c
index 1a7681502f62..1050f4a94a14 100644
--- a/drivers/remoteproc/ti_k3_r5_remoteproc.c
+++ b/drivers/remoteproc/ti_k3_r5_remoteproc.c
@@ -1266,7 +1266,7 @@ static int k3_r5_cluster_rproc_init(struct 
platform_device *pdev)
                        goto out;
                }
 
-               ret = rproc_add(rproc);
+               ret = devm_rproc_add(dev, rproc);
                if (ret)
                        dev_err_probe(dev, ret, "rproc_add failed\n");
 
@@ -1355,8 +1355,6 @@ static void k3_r5_cluster_rproc_exit(void *data)
                }
 
                mbox_free_channel(kproc->mbox);
-
-               rproc_del(rproc);
        }
 }
 
-- 
2.34.1


Reply via email to