Any write access to the IMEM region when the Q6 is setting up XPU
protection on it will result in a XPU violation. Fix this by ensuring
IMEM writes related to the MBA post-mortem logs happen before the Q6
is brought out of reset.
Fixes: 318130cc9362 ("remoteproc: qcom_q6v5_mss: Add MBA log extraction 
support")
Signed-off-by: Sibi Sankar <quic_si...@quicinc.com>
---
 drivers/remoteproc/qcom_q6v5_mss.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/remoteproc/qcom_q6v5_mss.c 
b/drivers/remoteproc/qcom_q6v5_mss.c
index 2a42215ce8e0..32c3531b20c7 100644
--- a/drivers/remoteproc/qcom_q6v5_mss.c
+++ b/drivers/remoteproc/qcom_q6v5_mss.c
@@ -1162,6 +1162,9 @@ static int q6v5_mba_load(struct q6v5 *qproc)
                goto disable_active_clks;
        }
 
+       if (qproc->has_mba_logs)
+               qcom_pil_info_store("mba", qproc->mba_phys, MBA_LOG_SIZE);
+
        writel(qproc->mba_phys, qproc->rmb_base + RMB_MBA_IMAGE_REG);
        if (qproc->dp_size) {
                writel(qproc->mba_phys + SZ_1M, qproc->rmb_base + 
RMB_PMI_CODE_START_REG);
@@ -1172,9 +1175,6 @@ static int q6v5_mba_load(struct q6v5 *qproc)
        if (ret)
                goto reclaim_mba;
 
-       if (qproc->has_mba_logs)
-               qcom_pil_info_store("mba", qproc->mba_phys, MBA_LOG_SIZE);
-
        ret = q6v5_rmb_mba_wait(qproc, 0, 5000);
        if (ret == -ETIMEDOUT) {
                dev_err(qproc->dev, "MBA boot timed out\n");
-- 
2.34.1


Reply via email to