> On May 31, 2024, at 15:21, Miroslav Benes <mbe...@suse.cz> wrote: > > Hi, > > On Fri, 31 May 2024, zhang warden wrote: > > you have not replied to my questions/feedback yet. > > Also, I do not think that unlikely changes anything here. It is a simple > branch after all. > > Miroslav Hi Miroslav, Sorry for my carelessness. I apologise for my ignorance. > Second, livepatch is > already use ftrace for functional replacement, I don’t think it is a > good choice of using kernel tracing tool to trace a patched function. I admit that ftrace can use for tracing the new patched function. But for some cases, user who what to know the state of this function can easily cat the 'called' interface. It is more convenient than using ftrace to trace the state. And for the unlikely branch, isn’t the complier will compile this branch into a cold branch that will do no harm to the function performance? Regards, Wardenjohn
- Re: [PATCH] livepatch: introduce klp_func called interface Dan Carpenter
- [PATCH] livepatch: introduce klp_func called interface Wardenjohn
- Re: [PATCH] livepatch: introduce klp_func called inter... Miroslav Benes
- Re: [PATCH] livepatch: introduce klp_func called i... zhang warden
- Re: [PATCH] livepatch: introduce klp_func call... Miroslav Benes
- Re: [PATCH] livepatch: introduce klp_func ... Petr Mladek
- Re: [PATCH] livepatch: introduce klp_... zhang warden
- Re: [PATCH] livepatch: introduce klp_... zhang warden
- Re: [PATCH] livepatch: introduce ... Miroslav Benes
- Re: [PATCH] livepatch: introduce ... zhang warden
- Re: [PATCH] livepatch: introduce ... Miroslav Benes
- Re: [PATCH] livepatch: introduce ... zhang warden
- Re: [PATCH] livepatch: introduce klp_... Song Liu
- Re: [PATCH] livepatch: introduce ... Miroslav Benes
- Re: [PATCH] livepatch: introduce ... Song Liu
- Re: [PATCH] livepatch: introduce ... zhang warden
- Re: [PATCH] livepatch: introduce ... zhang warden
- Re: [PATCH] livepatch: introduce ... Miroslav Benes
- Re: [PATCH] livepatch: introduce klp_func ... Joe Lawrence
- Re: [PATCH] livepatch: introduce klp_... zhang warden