On Tue, May 21, 2024 at 04:22:21PM +0200, Oleg Nesterov wrote:
> On 05/21, Jiri Olsa wrote:
> >
> > Currently the application with enabled shadow stack will crash
> > if it sets up return uprobe. The reason is the uretprobe kernel
> > code changes the user space task's stack, but does not update
> > shadow stack accordingly.
> >
> > Adding new functions to update values on shadow stack and using
> > them in uprobe code to keep shadow stack in sync with uretprobe
> > changes to user stack.
>
> I don't think my ack has any value in this area but looks good to me.
>
> Reviewed-by: Oleg Nesterov <o...@redhat.com>
>
>
> > Fixes: 8b1c23543436 ("x86/shstk: Add return uprobe support")
>
> Hmm... Was this commit ever applied?
should have been:
488af8ea7131 x86/shstk: Wire in shadow stack interface
will send new version
thanks,
jirka
>
> Oleg.
>
