On Wed, 23 Jan 2008, Mathieu Desnoyers wrote:
> * Steven Rostedt ([EMAIL PROTECTED]) wrote: > > This annotates NMI functions with notrace. Some tracers may be able > > to live with this, but some cannot. So we turn off NMI tracing. > > > > One solution might be to make a notrace_nmi which would only turn > > off NMI tracing if a trace utility needed it off. > > > Is this still needed with the atomic clocksource read ? This never had to do with the clocksource. The tracer itself isn't atomic against NMIs. hmm, it may actually be. It does a tracer disable for the CPU by an atomic_inc and this would prevent the NMI from causing harm. I'll test without this patch and see what happens when I turn on a high rate of NMIS. I still want to add a bit more notraces around for the simple reason of cleaning up the output and prehaps speeding up the code a bit. -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/