On Wed, 03 Mar 2021 07:51:06 +0100, Heiner Kallweit said: > > # Firmware loader > > CONFIG_EXTRA_FIRMWARE="rtl_nic/rtl8106e-1.fw" > > CONFIG_EXTRA_FIRMWARE_DIR="/lib/firmware" > > > This is wrong, simply remove it.
> > But then I take a closer look at drivers/net/ethernet/realtek/r8169_main.c > > #define FIRMWARE_8168D_1 "rtl_nic/rtl8168d-1.fw" > > #define FIRMWARE_8168D_2 "rtl_nic/rtl8168d-2.fw" > > #define FIRMWARE_8168E_1 "rtl_nic/rtl8168e-1.fw" Yes, but then how are *these* filenames supposed to work? Is a userspace helper supposed to be smart enough to append the .xz, and the EXTRA_FIRMWARE variant for embedding out-of-tree firmware has to point at an uncompressed version?