From: YueHaibing <[email protected]>

[ Upstream commit af982da9a612295a91f367469f8945c916a20dfd ]

Fix inconsistent IS_ERR and PTR_ERR in cifs_find_swn_reg(). The proper
pointer to be passed as argument to PTR_ERR() is share_name.

This bug was detected with the help of Coccinelle.

Fixes: bf80e5d4259a ("cifs: Send witness register and unregister commands to 
userspace daemon")
Signed-off-by: YueHaibing <[email protected]>
Reviewed-by: Samuel Cabrero <[email protected]>
Signed-off-by: Steve French <[email protected]>
Signed-off-by: Sasha Levin <[email protected]>
---
 fs/cifs/cifs_swn.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/cifs/cifs_swn.c b/fs/cifs/cifs_swn.c
index d35f599aa00e6..f2d730fffccb3 100644
--- a/fs/cifs/cifs_swn.c
+++ b/fs/cifs/cifs_swn.c
@@ -272,7 +272,7 @@ static struct cifs_swn_reg *cifs_find_swn_reg(struct 
cifs_tcon *tcon)
        if (IS_ERR(share_name)) {
                int ret;
 
-               ret = PTR_ERR(net_name);
+               ret = PTR_ERR(share_name);
                cifs_dbg(VFS, "%s: failed to extract share name from target 
'%s': %d\n",
                                __func__, tcon->treeName, ret);
                kfree(net_name);
-- 
2.27.0



Reply via email to