On Tue, Feb 23, 2021 at 04:06:30PM +0800, dingsen...@163.com wrote: > From: dingsenjie <dingsen...@yulong.com> > > Remove superfluous "breaks", as there is a "return" before them. > > Signed-off-by: dingsenjie <dingsen...@yulong.com>
You are at least the fourth person who sends this patch[1]. The things I wrote in reply to the latest submission still applies: - the Subject is wrong, it should use a prefix similar to "serial: imx:". - I personally like the breaks for clarity. - If people agree enough to outvote me, please at least add an empty line instead of just removing the break to visually separate the cases. Thanks Uwe [1] https://lore.kernel.org/r/20201026125142.21105-1-zhangqilo...@huawei.com https://lore.kernel.org/r/20201020130709.28096-1-t...@redhat.com https://lore.kernel.org/r/20201107140129.kpfhanzjidvdg...@pengutronix.de -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |
signature.asc
Description: PGP signature
