Em Tue, Feb 16, 2021 at 03:37:20PM -0500, Nicholas Fraser escreveu:
> This removes the redundant checks bfd_check_format() and
> bfd_target_elf_flavour. They were previously checking different files.
you forgot the:
Signed-off-by: Nicholas Fraser <nfra...@codeweavers.com>
I'm adding it, ok?
I'm also addressing Jiri's remark about spaces surrounding |
- Arnaldo
> ---
> tools/perf/util/symbol.c | 9 ---------
> 1 file changed, 9 deletions(-)
>
> diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c
> index 492c873713cc..08f6f57c84fd 100644
> --- a/tools/perf/util/symbol.c
> +++ b/tools/perf/util/symbol.c
> @@ -1586,15 +1586,6 @@ int dso__load_bfd_symbols(struct dso *dso, const char
> *debugfile)
> if (section)
> dso->text_offset = section->vma - section->filepos;
>
> - if (!bfd_check_format(abfd, bfd_object)) {
> - pr_debug2("%s: cannot read %s bfd file.\n", __func__,
> - debugfile);
> - goto out_close;
> - }
> -
> - if (bfd_get_flavour(abfd) == bfd_target_elf_flavour)
> - goto out_close;
> -
> symbols_size = bfd_get_symtab_upper_bound(abfd);
> if (symbols_size == 0) {
> bfd_close(abfd);
> --
> 2.30.1
--
- Arnaldo
