On Wed, Feb 17, 2021 at 04:45:51PM +0100, Petr Mladek wrote: > On Tue 2021-02-16 21:05:48, Chris Down wrote: > > Johannes Weiner writes: > > > On Tue, Feb 16, 2021 at 05:27:08PM +0000, Chris Down wrote: > > > > Petr Mladek writes: > > > > > I wonder if we could find a better name for the configure switch. > > > > > I have troubles to imagine what printk enumeration might mean. > > > > > Well, it might be because I am not a native speaker. > > > > > > > > > > Anyway, the word "enumeration" is used only in the configure option. > > > > > Everything else is "printk_fmt" > > > > > > > > > > What about DEBUG_PRINTK_FORMATS? > > > > > > > > Hmm, I don't like DEBUG_PRINTK_FMTS because it's not about debugging, > > > > it's > > > > about enumeration, I guess :-) > > > > > > > > The name should reflect that this catalogues the available printks in > > > > the > > > > kernel -- "debugging" seems to imply something different. > > > > > > > > I'm ok with a different name like "printk catalogue" or something like > > > > that > > > > if you prefer. Personally I think "printk enumeration" is fairly clear > > > > -- > > > > it's about enumerating the available printks -- but anything that > > > > captures > > > > that spirit is fine. > > > > > > How about config PRINTK_INDEX? > > > > Ah yes, I also like that. PRINTK_INDEX is fine from my perspective and is > > more straightforward than "enumeration", thanks. > > It is better than enumeration. But there is still the same > problem. The word "index" is used neither in the code > nor in the debugfs interface. It is like enabling cars and > seeing apples.
I assumed code and interface would then also be changed to printk_index, struct printk_index_section, pi_foo, ...
