On Tue 2021-02-02 09:59:11, Abel Wu wrote: > > > > On Feb 1, 2021, at 6:52 PM, Pavel Machek <pa...@ucw.cz> wrote: > > > > On Mon 2021-02-01 02:50:41, Abel Wu wrote: > >> The @power_kobj is initialized in pm_init() which is the same > >> initcall level as pm_disk_init(). Although this dependency is > >> guaranteed based on the current initcall serial execution model, > >> it would still be better do a cost-less sanity check to avoid > >> oops once the dependency is broken. > > > > I don't believe this is good idea. If the dependency is ever broken, > > this will make failure more subtle and harder to debug. > > Thanks for reviewing. I think the cmdline parameter initcall_debug will > help in this case. > Actually we are trying to make initcalls being called asynchronously to > reduce boot time which is crucial to our cloud-native business. And we > resolve this kind of dependencies by retrying failed initcalls.
And this patch is okay if that gets mainlined, but not before.
Best regards,
Pavel
--
http://www.livejournal.com/~pavelmachek
signature.asc
Description: Digital signature
