On Dec 29, 2007 9:42 AM, Peter Zijlstra <[EMAIL PROTECTED]> wrote: > > On Sat, 2007-12-29 at 09:36 +0800, Dave Young wrote: > > On Dec 29, 2007 9:29 AM, Peter Zijlstra <[EMAIL PROTECTED]> wrote: > > > > > > > > > I'm pretty sure you didn't boot that kernel with lockdep enabled. > > Yes, I will try rebuild with lockdep and test. > > I'll fail miserably :-) > > >From your other mail: > > No, I checked the config , lockdep is indeed enabled. But I will try > > to test with the lock debug options enabled in a while. > > You need to actually boot the kernel to get effective reports from > lockdep, it'll build just fine. > > > > Also, most, if not all, of your patches miss a patch description. > > > > Does the description really needed for it? IMHO, the subject is enough > > to descript the patches. > > Preferably, the subject might convey what you are doing, but the full > description should at least add to that by telling _why_ you are doing > that.
Hm, actually it's not so hard, but If I resend the 12 patches seems like spam to lkml :-). Of cource, if you all don't mind and it is really needed, I will do that. > > Also, I don't think your series is bisectable, ie. 1/12 changes > device::sem -> device::mutex, and 12/12 changes a user of it. Sorry, I don't use git tools now. Could you tell me how to fix it? thanks in advance. Regards dave -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
