+Cc: LKML and Peng On Wed, Jan 20, 2021 at 6:48 PM Mihai Carabas <mihai.cara...@oracle.com> wrote: > > Hello Andy, > > Some time ago you have created a patchset where you have combined > ACPI/MMIO into a single driver for pvpanic: > > commit f104060813fe79350565b68c1098fcea050a6504 > Author: Andy Shevchenko <andriy.shevche...@linux.intel.com> > Date: Wed Dec 9 22:36:41 2020 +0200 > > misc: pvpanic: Combine ACPI and platform drivers > > I also have sent some patches where I created a driver framework for > adding a PCI driver. These being said, I want to send again another > patchset to add a PVPANIC PCI driver, but I am not sure what is the > right approach you would like to see: > - create a totally different driver for pvpanic pci and naming it > pvpanic-pci.c with its config PVPANIC_PCI > - create the framework I have sent before but having only two buses > (ACPI/MMIO in one file and PCI in another)
Generic approach is to have three files: - core part - platform driver - PCI driver in this case. > In qemu they are basically two different devices (one is -device pvpanic > and the other is -device pvpanic-pci) > > I could not find any precedence in other drivers. Your input is welcome. -- With Best Regards, Andy Shevchenko
