On Mon, Jan 04, 2021 at 12:45:58PM +0900, Masami Hiramatsu wrote:
> Hrm, I meant setting the flags used in the resume_execution() afterwards.
> Since the instruction itself (not only opcode but also oprands) was
> also analyzed in other places, so I like the set_resume_flags() for it.
Your call but I still think that set_resume_flags() is misleading. You
even have in the comment above it:
"Analyze the opcode and set resume flags."
so it is doing some insn analysis and setting flags as a result.
But I won't insist - you're the one who's going to be staring at that
code.
:-)
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
