On Tuesday 18 December 2007 09:42, David Howells wrote: > Nick Piggin <[EMAIL PROTECTED]> wrote: > > This is pretty nasty. > > Why? If the fs doesn't set PG_private or PG_fscache on any pages before > calling read_cache_pages(), there's no difference.
It is conceptually wrong. > Furthermore, the differences only crop up in the error handling paths. That doesn't make it any better. > > I would suggest either to have the function return the number of pages > > that were added to pagecache, > > Which helps how? So the caller can do their own error handling / cleanup. > > or just open code it. > > Well, I could give an alternative read_cache_pages(), I suppose, for just > this situation, but that means there are two parallel functions which then > both need to be maintained. I would be OK with that. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
