在 2020/12/8 上午6:09, Yu Zhao 写道:
>  
>               __count_vm_events(PGACTIVATE, nr_pages);
> @@ -543,14 +542,14 @@ static void lru_deactivate_file_fn(struct page *page, 
> struct lruvec *lruvec)
>                * It can make readahead confusing.  But race window
>                * is _really_ small and  it's non-critical problem.
>                */
> -             add_page_to_lru_list(page, lruvec, lru);
> +             add_page_to_lru_list(page, lruvec);
>               SetPageReclaim(page);
>       } else {
>               /*
>                * The page's writeback ends up during pagevec
>                * We moves tha page into tail of inactive.
>                */
> -             add_page_to_lru_list_tail(page, lruvec, lru);
> +             add_page_to_lru_list_tail(page, lruvec);
>               __count_vm_events(PGROTATED, nr_pages);
>       }
>  
> @@ -570,7 +569,7 @@ static void lru_deactivate_fn(struct page *page, struct 
> lruvec *lruvec)
>               del_page_from_lru_list(page, lruvec, lru + LRU_ACTIVE);
>               ClearPageActive(page);
>               ClearPageReferenced(page);
> -             add_page_to_lru_list(page, lruvec, lru);
> +             add_page_to_lru_list(page, lruvec);
>  
>               __count_vm_events(PGDEACTIVATE, nr_pages);
>               __count_memcg_events(lruvec_memcg(lruvec), PGDEACTIVATE,

seems leave the lru = xxx out, could save 2 function calling in 
lru_deactivate_file_fn(), is this right?

Reply via email to