Greg KH <[EMAIL PROTECTED]> writes: > On Thu, Dec 13, 2007 at 08:59:44PM -0700, Eric W. Biederman wrote: >> [EMAIL PROTECTED] writes: >> >> > Forward port of coherent-mmap.patch and sysfs-bin-ioctl.patch to x86 tree. >> > >> > TBD: Do we need the ioctl interface to sysfs or get the type attribute >> > through a different sysfs file. And then actually specify the attribute >> > while doing pci_mmap_page_range ;-) >> >> This ioctl is not connected up. So regardless of the wisdom of ioctls on >> sysfs adding the infrastructure and then not using it is broken. > > Ok, I guess the "use an ioctl on a binary file in sysfs for PCI devices" > makes a bit more sense (hint, next time explain this in the changelog > instead of just saying that it is being added), but I would like to see > how this is all hooked up before passing final judgement on it.
The obvious thing to do would be to hook it up like: drivers/pci/proc.c:proc_bus_pci_ioctl. Eric -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
