Hi Stefan, The driver was ported from latest ASPEED BSP, so I only test with ECC-on/off from u-boot and check if driver runs correctly.
The test doc you provided is very nice and detailed, I'll try to reproduce the injection test in v2 patch. Thanks, Troy Lee > -----Original Message----- > From: Stefan Schaeckeler (sschaeck) <sscha...@cisco.com> > Sent: Monday, November 30, 2020 5:16 PM > To: Troy Lee <troy_...@aspeedtech.com>; Rob Herring <robh...@kernel.org>; > Joel Stanley <j...@jms.id.au>; Andrew Jeffery <and...@aj.id.au>; Borislav > Petkov <b...@alien8.de>; Mauro Carvalho Chehab <mche...@kernel.org>; > Tony Luck <tony.l...@intel.com>; James Morse <james.mo...@arm.com>; > Robert Richter <rrich...@marvell.com>; open list:OPEN FIRMWARE AND > FLATTENED DEVICE TREE BINDINGS <devicet...@vger.kernel.org>; moderated > list:ARM/ASPEED MACHINE SUPPORT <linux-arm-ker...@lists.infradead.org>; > moderated list:ARM/ASPEED MACHINE SUPPORT > <linux-asp...@lists.ozlabs.org>; open list <linux-kernel@vger.kernel.org>; > open list:EDAC-CORE <linux-e...@vger.kernel.org> > Cc: leet...@gmail.com; Ryan Chen <ryan_c...@aspeedtech.com>; Stefan > Schaeckeler <schae...@gmx.net> > Subject: Re: [PATCH 3/3] edac: Supporting AST2400 and AST2600 edac driver > > Hello Troy, > > > Adding AST2400 and AST2600 edac driver support. > > > > Signed-off-by: Troy Lee <troy_...@aspeedtech.com> > > --- > > drivers/edac/Kconfig | 6 +- > > drivers/edac/aspeed_edac.c | 114 +++++++++++++++++++++++++++++-------- > > 2 files changed, 94 insertions(+), 26 deletions(-) > > Uh, there are quite some non-trivial changes. I'll have a look over the coming > weekend. > > Testing an edac driver comes with challenges. Did you test your code? If so, > how? > > That's how I was testing my original edac 2500 driver > http://students.engr.scu.edu/~sschaeck/misc/aspeed-edac.html > > Stefan
