Hi, On Tue, Nov 24, 2020 at 12:10:31PM -0800, Prashant Malani wrote: > Both partner and cable have identity VDOs. These are listed separately > in the Documentation/ABI/testing/sysfs-class-typec. Factor these out > into a common location to avoid the duplication. > > Signed-off-by: Prashant Malani <pmal...@chromium.org> > Acked-by: Heikki Krogerus <heikki.krogeu...@linux.intel.com> I copied the Acked-by line from v3 [1] as is, but looks like there was a typo there and the email address should be "heikki.kroge...@linux.intel.com".
Please let me know if it's fine as is or whether I should send another patchset. [1] https://lore.kernel.org/linux-usb/20201110105225.gh1224...@kuha.fi.intel.com/ > --- > > Changes in v4: > - Rebased on top of the usb-next tree. > - Added Acked-by tag from pevious version's review. > - Corrected a typo ('syfs' -> 'sysfs') in the subject line. > > Patch first introduced in v3. > > Documentation/ABI/testing/sysfs-class-typec | 59 ++++++--------------- > 1 file changed, 17 insertions(+), 42 deletions(-) > > diff --git a/Documentation/ABI/testing/sysfs-class-typec > b/Documentation/ABI/testing/sysfs-class-typec > index 4eccb343fc7b..88ffc14d4cd2 100644 > --- a/Documentation/ABI/testing/sysfs-class-typec > +++ b/Documentation/ABI/testing/sysfs-class-typec > @@ -147,42 +147,6 @@ Description: > during Power Delivery discovery. This file remains hidden until > a value > greater than or equal to 0 is set by Type C port driver. > > -What: /sys/class/typec/<port>-partner>/identity/ > -Date: April 2017 > -Contact: Heikki Krogerus <heikki.kroge...@linux.intel.com> > -Description: > - This directory appears only if the port device driver is capable > - of showing the result of Discover Identity USB power delivery > - command. That will not always be possible even when USB power > - delivery is supported, for example when USB power delivery > - communication for the port is mostly handled in firmware. If the > - directory exists, it will have an attribute file for every VDO > - in Discover Identity command result. > - > -What: /sys/class/typec/<port>-partner/identity/id_header > -Date: April 2017 > -Contact: Heikki Krogerus <heikki.kroge...@linux.intel.com> > -Description: > - ID Header VDO part of Discover Identity command result. The > - value will show 0 until Discover Identity command result becomes > - available. The value can be polled. > - > -What: /sys/class/typec/<port>-partner/identity/cert_stat > -Date: April 2017 > -Contact: Heikki Krogerus <heikki.kroge...@linux.intel.com> > -Description: > - Cert Stat VDO part of Discover Identity command result. The > - value will show 0 until Discover Identity command result becomes > - available. The value can be polled. > - > -What: /sys/class/typec/<port>-partner/identity/product > -Date: April 2017 > -Contact: Heikki Krogerus <heikki.kroge...@linux.intel.com> > -Description: > - Product VDO part of Discover Identity command result. The value > - will show 0 until Discover Identity command result becomes > - available. The value can be polled. > - > > USB Type-C cable devices (eg. /sys/class/typec/port0-cable/) > > @@ -219,17 +183,28 @@ Description: > This file remains hidden until a value greater than or equal to > 0 > is set by Type C port driver. > > -What: /sys/class/typec/<port>-cable/identity/ > + > +USB Type-C partner/cable Power Delivery Identity objects > + > +NOTE: The following attributes will be applicable to both > +partner (e.g /sys/class/typec/port0-partner/) and > +cable (e.g /sys/class/typec/port0-cable/) devices. Consequently, the example > file > +paths below are prefixed with "/sys/class/typec/<port>-{partner|cable}/" to > +reflect this. > + > +What: /sys/class/typec/<port>-{partner|cable}/identity/ > Date: April 2017 > Contact: Heikki Krogerus <heikki.kroge...@linux.intel.com> > Description: > This directory appears only if the port device driver is capable > of showing the result of Discover Identity USB power delivery > command. That will not always be possible even when USB power > - delivery is supported. If the directory exists, it will have an > - attribute for every VDO returned by Discover Identity command. > + delivery is supported, for example when USB power delivery > + communication for the port is mostly handled in firmware. If the > + directory exists, it will have an attribute file for every VDO > + in Discover Identity command result. > > -What: /sys/class/typec/<port>-cable/identity/id_header > +What: > /sys/class/typec/<port>-{partner|cable}/identity/id_header > Date: April 2017 > Contact: Heikki Krogerus <heikki.kroge...@linux.intel.com> > Description: > @@ -237,7 +212,7 @@ Description: > value will show 0 until Discover Identity command result becomes > available. The value can be polled. > > -What: /sys/class/typec/<port>-cable/identity/cert_stat > +What: > /sys/class/typec/<port>-{partner|cable}/identity/cert_stat > Date: April 2017 > Contact: Heikki Krogerus <heikki.kroge...@linux.intel.com> > Description: > @@ -245,7 +220,7 @@ Description: > value will show 0 until Discover Identity command result becomes > available. The value can be polled. > > -What: /sys/class/typec/<port>-cable/identity/product > +What: /sys/class/typec/<port>-{partner|cable}/identity/product > Date: April 2017 > Contact: Heikki Krogerus <heikki.kroge...@linux.intel.com> > Description: > -- > 2.29.2.454.gaff20da3a2-goog >
