This code became dead after commit b9148c6b80d802dbc2a7530b29915a80432e50c7 (which BTW doesn't seem to have changed any behaviour) and can therefore be removed.
Spotted by the Coverity checker. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- --- linux-2.6/fs/nfs/direct.c.old 2007-12-02 21:54:53.000000000 +0100 +++ linux-2.6/fs/nfs/direct.c 2007-12-02 21:55:10.000000000 +0100 @@ -897,15 +897,12 @@ ssize_t nfs_file_direct_write(struct kio if (!count) goto out; /* return 0 */ retval = -EINVAL; if ((ssize_t) count < 0) goto out; - retval = 0; - if (!count) - goto out; retval = nfs_sync_mapping(mapping); if (retval) goto out; retval = nfs_direct_write(iocb, iov, nr_segs, pos, count); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/