Fix to return a negative error code from the error handling case
instead of 0 in function _ib_modify_qp(), as done elsewhere in this
function.

Fixes: 51aab12631dd ("RDMA/core: Get xmit slave for LAG")
Reported-by: Hulk Robot <hul...@huawei.com>
Signed-off-by: Chen Zhou <chenzho...@huawei.com>
---
 drivers/infiniband/core/verbs.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/infiniband/core/verbs.c b/drivers/infiniband/core/verbs.c
index 740f8454b6b4..3d895cc41c3a 100644
--- a/drivers/infiniband/core/verbs.c
+++ b/drivers/infiniband/core/verbs.c
@@ -1698,8 +1698,10 @@ static int _ib_modify_qp(struct ib_qp *qp, struct 
ib_qp_attr *attr,
                        slave = rdma_lag_get_ah_roce_slave(qp->device,
                                                           &attr->ah_attr,
                                                           GFP_KERNEL);
-                       if (IS_ERR(slave))
+                       if (IS_ERR(slave)) {
+                               ret = PTR_ERR(slave);
                                goto out_av;
+                       }
                        attr->xmit_slave = slave;
                }
        }
-- 
2.20.1

Reply via email to