On Wed, Dec 05, 2007 at 02:15:35PM +0100, Stefan Richter wrote: > > [EMAIL PROTECTED] wrote: > >> @@ -275,7 +270,7 @@ int dma_region_mmap(struct dma_region *d > >> if (!dma->kvirt) > >> return -EINVAL; > >> > >> - /* must be page-aligned */ > >> + /* must be page-aligned (XXX: comment is wrong, we could allow pgoff) */ > >> if (vma->vm_pgoff != 0) > >> return -EINVAL; > >> > > > > Are you sure that the comment is wrong? Could it be that there are > > assumptions elsewhere which require page alignment? (I should be able > > to answer that, but I'm not.) > > PS: Assumed the comment is wrong, is the code wrong then too?
The mmap / fault code _seems_ OK. The check here is only wrong in that it doesn't prevent non-page-aligned mappings (the core VM code already does). -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
