Re: [PATCH 35/36] tty: synclink: Mark disposable variables as __always_unused

[Jiri Slaby]

On 04. 11. 20, 20:35, Lee Jones wrote:

Fixes the following W=1 kernel build warning(s):

  drivers/tty/synclink.c: In function ‘usc_reset’:
  drivers/tty/synclink.c:5571:6: warning: variable ‘readval’ set but not used 
[-Wunused-but-set-variable]
  drivers/tty/synclink.c: In function ‘mgsl_load_pci_memory’:
  drivers/tty/synclink.c:7267:16: warning: variable ‘Dummy’ set but not used 
[-Wunused-but-set-variable]

Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org>
Cc: Jiri Slaby <jirisl...@kernel.org>
Cc: pau...@microgate.com
Signed-off-by: Lee Jones <lee.jo...@linaro.org>
---
  drivers/tty/synclink.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/tty/synclink.c b/drivers/tty/synclink.c
index c8324d58ef564..8ed64b1e7c378 100644
--- a/drivers/tty/synclink.c
+++ b/drivers/tty/synclink.c
@@ -5568,7 +5568,7 @@ static void usc_load_txfifo( struct mgsl_struct *info )
  static void usc_reset( struct mgsl_struct *info )
  {
        int i;
-       u32 readval;
+       u32 __always_unused readval;

The same as in synclinkmp.

/* Set BIT30 of Misc Control Register */

        /* (Local Control Register 0x50) to force reset of USC. */
@@ -7264,7 +7264,7 @@ static void mgsl_load_pci_memory( char* TargetPtr, const 
char* SourcePtr,

unsigned short Intervalcount = count / PCI_LOAD_INTERVAL;

        unsigned short Index;
-       unsigned long Dummy;
+       unsigned long __always_unused Dummy;

You can kill it completely.

for ( Index = 0 ; Index < Intervalcount ; Index++ )

        {

thanks,
--
js
suse labs