Hi Daniel,
On Sat, Oct 24, 2020 at 09:28:07PM +0100, Dan Scally wrote:
...
> >> +int cio2_bridge_build(struct pci_dev *cio2)
> >> +{
> >> + struct fwnode_handle *fwnode;
> >> + int ret;
> >> +
> >> + pci_dev_get(cio2);
> > Could you check that this isn't used by more than one user? The current
> > implementation assumes that. I'm not sure if there could be more instances
> > of CIO2 but if there were, that'd be an issue currently.
>
> I can check; can't think of anything better than just failing out if it
> turns out to be in use already though - any ideas or is that appropriate?
A negative error code would be appropriate, e.g. -EBUSY.
--
Regards,
Sakari Ailus
