On Thu, Oct 22, 2020 at 12:13:54AM -0700, Prashant Malani wrote: > Thanks for reviewing the patch, Greg. > > On Wed, Oct 21, 2020 at 11:56 PM Greg KH <gre...@linuxfoundation.org> wrote: > > > > On Wed, Oct 21, 2020 at 11:15:54PM -0700, Prashant Malani wrote: > > > > > > diff --git a/Documentation/ABI/testing/sysfs-class-typec > > > b/Documentation/ABI/testing/sysfs-class-typec > > > index b834671522d6..16440a236b66 100644 > > > --- a/Documentation/ABI/testing/sysfs-class-typec > > > +++ b/Documentation/ABI/testing/sysfs-class-typec > > > @@ -170,6 +170,14 @@ Description: > > > will show 0 until Discover Identity command result becomes > > > available. The value can be polled. > > > > > > +What: > > > /sys/class/typec/<port>-partner/identity/product_type_vdo > > > +Date: October 2020 > > > +Contact: Prashant Malani <pmal...@chromium.org> > > > +Description: > > > + Product Type VDOs part of Discover Identity command result. > > > 3 values > > > + are displayed (for the 3 possible Product Type VDOs), one > > > per line. > > > > sysfs is "one value per file", not "one value per line". This is not > > ok. > > I see. Would listing these out as three separate vdos (i.e vdo0, vdo1, > vdo2) be better?
Given that your current implementation is not acceptable, something has to change :) thanks, greg k-h
