On Thu, Oct 8, 2020 at 6:18 PM Joe Perches <j...@perches.com> wrote:
>
> On Thu, 2020-10-08 at 13:50 +0200, Lukas Bulwahn wrote:
> > Dear Joe, dear Dwaipayan,
> >
> > while maintaining MAINTAINERS, I noticed that the REPEATED_WORD check,
> > which in general is a great addition to checkpatch.pl, generates a massive
> > number of warnings due to one specific pattern in the MAINTAINERS file:
>
> I didn't actually check if there were many
> new false positives, but
> clearly that's one.
>
> Maybe exclude the MAINTAINERS file?
>
> - if ($rawline =~ /^\+/ || $in_commit_log) {
> + if (($rawline =~ /^\+/ || $in_commit_log) && $realfile ne
> "MAINTAINERS") {
>
> Maybe add git to the check for "long long"?
>
> - next if ($first eq 'long');
> + next if ($first =~ /^(?:long|git)$/);
>
>
>
Hi,
It does resolve all the warnings concerned.
But could we also exclude documentation type blocks like:
/**
* @size size of access
*/
There were quite a few of these in include/linux/instrumented.
And also it isn't case sensitive. So the line
"the the word is repeated" generates a warning, but
"The the word is repeated" doesn't generate anything.
Thanks,
Dwaipayan.
