From: Oleh Kravchenko <o...@kaa.org.ua>

[ Upstream commit 7c6082b903ac28dc3f383fba57c6f9e7e2594178 ]

Error was detected by PVS-Studio:
V512 A call of the 'sprintf' function will lead to overflow of
the buffer 'led_data->led_cdev_name'.

Acked-by: Jacek Anaszewski <jacek.anaszew...@gmail.com>
Acked-by: Pavel Machek <pa...@ucw.cz>
Signed-off-by: Oleh Kravchenko <o...@kaa.org.ua>
Signed-off-by: Pavel Machek <pa...@ucw.cz>
Signed-off-by: Sasha Levin <sas...@kernel.org>
---
 drivers/leds/leds-mlxreg.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/leds/leds-mlxreg.c b/drivers/leds/leds-mlxreg.c
index 1ee48cb21df95..022e973dc7c31 100644
--- a/drivers/leds/leds-mlxreg.c
+++ b/drivers/leds/leds-mlxreg.c
@@ -209,8 +209,8 @@ static int mlxreg_led_config(struct mlxreg_led_priv_data 
*priv)
                        brightness = LED_OFF;
                        led_data->base_color = MLXREG_LED_GREEN_SOLID;
                }
-               sprintf(led_data->led_cdev_name, "%s:%s", "mlxreg",
-                       data->label);
+               snprintf(led_data->led_cdev_name, 
sizeof(led_data->led_cdev_name),
+                        "mlxreg:%s", data->label);
                led_cdev->name = led_data->led_cdev_name;
                led_cdev->brightness = brightness;
                led_cdev->max_brightness = LED_ON;
-- 
2.25.1



Reply via email to