Hi! On Mon, Sep 28, 2020 at 02:27:39PM +0800, Kevin Tang wrote: > From: Kevin Tang <kevin.t...@unisoc.com> > > Adds MIPI DSI Master and MIPI DSI-PHY (D-PHY) > support for Unisoc's display subsystem. > > RFC v7: > - Fix DTC unit name warnings > - Fix the problem of maintainers > > Cc: Orson Zhai <orsonz...@gmail.com> > Cc: Chunyan Zhang <zhang.l...@gmail.com> > Signed-off-by: Kevin Tang <kevin.t...@unisoc.com> > --- > .../display/sprd/sprd,sharkl3-dsi-host.yaml | 98 > ++++++++++++++++++++++ > .../display/sprd/sprd,sharkl3-dsi-phy.yaml | 75 +++++++++++++++++ > 2 files changed, 173 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/display/sprd/sprd,sharkl3-dsi-host.yaml > create mode 100644 > Documentation/devicetree/bindings/display/sprd/sprd,sharkl3-dsi-phy.yaml > > diff --git > a/Documentation/devicetree/bindings/display/sprd/sprd,sharkl3-dsi-host.yaml > b/Documentation/devicetree/bindings/display/sprd/sprd,sharkl3-dsi-host.yaml > new file mode 100644 > index 0000000..b6bbf67 > --- /dev/null > +++ > b/Documentation/devicetree/bindings/display/sprd/sprd,sharkl3-dsi-host.yaml > @@ -0,0 +1,98 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/sprd/sprd,sharkl3-dsi-host.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Unisoc MIPI DSI Controller > + > +maintainers: > + - Kevin Tang <kevin.t...@unisoc.com> > + > +properties: > + compatible: > + const: sprd,sharkl3-dsi-host > + > + reg: > + maxItems: 1 > + description: > + Physical base address and length of the registers set for the device. > + > + interrupts: > + maxItems: 2 > + description: > + Should contain DSI interrupt. > + > + clocks: > + minItems: 1 > + > + clock-names: > + items: > + - const: clk_src_96m > + > + power-domains: > + maxItems: 1 > + description: A phandle to DSIM power domain node > + > + "#address-cells": > + const: 1 > + > + "#size-cells": > + const: 0 > + > + port@0: > + type: object > + description: > + A port node with endpoint definitions as defined in > + Documentation/devicetree/bindings/media/video-interfaces.txt. > + That port should be the input endpoint, usually coming from > + the associated DPU. > + port@1: > + type: object > + description: > + A port node with endpoint definitions as defined in > + Documentation/devicetree/bindings/media/video-interfaces.txt. > + That port should be the output endpoint, usually output to > + the associated DPHY.
Is there a specific reason you don't follow the OF-graph and have a ports subnode with your two port@X in there? Maxime
signature.asc
Description: PGP signature
