On Fri, Sep 18, 2020 at 03:38:43PM +0300, Dan Carpenter wrote:
> On Fri, Sep 18, 2020 at 12:20:02PM +0100, Charles Keepax wrote:
> > Fixes: 94cc89eb8fa5 ("regmap: debugfs: Fix handling of name string for
> > debugfs init delays")
> > Reported-by: kernel test robot <l...@intel.com>
> > Reported-by: Dan Carpenter <dan.carpen...@oracle.com>
> > Signed-off-by: Charles Keepax <ckee...@opensource.cirrus.com>
> > ---
> > drivers/base/regmap/regmap.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/base/regmap/regmap.c b/drivers/base/regmap/regmap.c
> > index d0f7cc574ff34..b24f14ea96d8a 100644
> > --- a/drivers/base/regmap/regmap.c
> > +++ b/drivers/base/regmap/regmap.c
> > @@ -706,9 +706,9 @@ struct regmap *__regmap_init(struct device *dev,
> > const char *lock_name)
> > {
> > struct regmap *map;
> > + int ret = -EINVAL;
> > enum regmap_endian reg_endian, val_endian;
> > int i, j;
> > - int ret;
> >
> > if (!config)
> > goto err;
>
> Hi Charles, this isn't enough. There are several goto err_map; paths
> were "ret" is zero. That will result in an Oops in the caller. It has
> to be an error code.
>
Aye, sorry thought it was just cause I removed the initialisation
but yeah there is more fall out. Apologies for mucking this up,
third time lucky hopefully.
Thanks,
Charles
