On Sun, Sep 13, 2020 at 09:40:56AM +0100, Chris Clayton wrote:
> Hi Greg and Arnd,
>
> On 24/08/2020 04:00, ricky...@realtek.com wrote:
> > From: Ricky Wu <ricky...@realtek.com>
> >
> > this power saving action in rtsx_pci_init_ocp() cause INTEL-NUC6 platform
> > missing card reader
> >
>
> In his changelog above, Ricky didn't mention that this patch fixes a
> regression that was introduced (in 5.1) by commit
> bede03a579b3.
>
> The patch that I posted to LKML contained the appropriate Fixes, etc tags.
> After discussion, the patch was changed to
> remove the code that effectively disables the RTS5229 cardreader on (at least
> some) Intel NUC boxes. I prepared the
> patch that Ricky submitted but he didn't include my Signed-off-by or the
> Fixes tag. I think the following needs to be
> added to the changelog.
>
> Fixes: bede03a579b3 ("misc: rtsx: Enable OCP for rts522a rts524a rts525a
> rts5260")
> Link: https://marc.info/?l=linux-kernel&m=159105912832257
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=204003
> Signed-off-by: Chris Clayton <chris2...@googlemail.com>
>
> bede03a579b3 introduced a bug which leaves the rts5229 PCI Express card
> reader on the Intel NUC6CAYH box.
>
> My main point, however, is that the patch is also needed in the 5.4
> (longterm) and 5.8 (stable) series kernels.
It's too late to change the commit log now that it is in my tree, but
once it hits Linus's tree for 5.9-rc1, I can backport it to those stable
trees if someone reminds me :)
thanks,
greg k-h
