On 05/09/20 10:26, Marc Zyngier wrote: > <random> > Maybe considering the irqchip stack along a vertical axis is the wrong > thing to do, and that looking at it as a volume would be marginally > better? > > How about innermost (close to the CPU) vs outermost (close to the > device)? > </random> >
I guess this is fairly subjective, but the inner/outer thing does click with me. I think the "issue" with the top / bottom wording is that existing data structures (domain / irq_data hierarchy) bias my interpretation of it, but it's upside down from the irq_chip stack representation. That's not the case of inner / outer where all I can think of is the actual chip layout (i.e. as an image of the distance from the CPUs). Anyway, that's enough psychoanalysis from me, the patches look fine - I also reran my quick rtcwake test on GICv2 (tests the WAKEUP_ARMED path). Feel free to add Reviewed-by: Valentin Schneider <valentin.schnei...@arm.com> to 1/4 & 3/4. > Thanks, > > M.
