Hi Andrew, I love your patch! Yet something to improve:
[auto build test ERROR on robh/for-next] [also build test ERROR on linux/master linus/master v5.9-rc2 next-20200828] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Andrew-Lunn/of-of_match_node-Make-stub-an-inline-function-to-avoid-W-1-warnings/20200828-102035 base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next config: i386-randconfig-r032-20200828 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 reproduce (this is a W=1 build): # save the attached .config to linux build tree make W=1 ARCH=i386 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <l...@intel.com> All errors (new ones prefixed by >>): drivers/mfd/max8998.c: In function 'max8998_i2c_get_driver_data': >> drivers/mfd/max8998.c:160:25: error: 'max8998_dt_match' undeclared (first >> use in this function) 160 | match = of_match_node(max8998_dt_match, i2c->dev.of_node); | ^~~~~~~~~~~~~~~~ drivers/mfd/max8998.c:160:25: note: each undeclared identifier is reported only once for each function it appears in # https://github.com/0day-ci/linux/commit/3213d0cc82c7a4e0e85e0db3da3da279460c833b git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Andrew-Lunn/of-of_match_node-Make-stub-an-inline-function-to-avoid-W-1-warnings/20200828-102035 git checkout 3213d0cc82c7a4e0e85e0db3da3da279460c833b vim +/max8998_dt_match +160 drivers/mfd/max8998.c ee999fb3f17faa Tomasz Figa 2013-06-25 154 8bace2d5b4baa0 Lee Jones 2014-02-03 155 static inline unsigned long max8998_i2c_get_driver_data(struct i2c_client *i2c, ee999fb3f17faa Tomasz Figa 2013-06-25 156 const struct i2c_device_id *id) ee999fb3f17faa Tomasz Figa 2013-06-25 157 { ee999fb3f17faa Tomasz Figa 2013-06-25 158 if (IS_ENABLED(CONFIG_OF) && i2c->dev.of_node) { ee999fb3f17faa Tomasz Figa 2013-06-25 159 const struct of_device_id *match; ee999fb3f17faa Tomasz Figa 2013-06-25 @160 match = of_match_node(max8998_dt_match, i2c->dev.of_node); 8bace2d5b4baa0 Lee Jones 2014-02-03 161 return (unsigned long)match->data; ee999fb3f17faa Tomasz Figa 2013-06-25 162 } ee999fb3f17faa Tomasz Figa 2013-06-25 163 8bace2d5b4baa0 Lee Jones 2014-02-03 164 return id->driver_data; ee999fb3f17faa Tomasz Figa 2013-06-25 165 } ee999fb3f17faa Tomasz Figa 2013-06-25 166 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
