It is not necessary to use src/dst as an intermediate variable for
assignment operation; Delete src/dst intermediate variables to avoid
unnecessary variable declarations.

Signed-off-by: Jianlin Lv <jianlin...@arm.com>
---
 drivers/net/vxlan.c | 16 ++++------------
 1 file changed, 4 insertions(+), 12 deletions(-)

diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
index b9fefe27e3e8..c00ca01ebe76 100644
--- a/drivers/net/vxlan.c
+++ b/drivers/net/vxlan.c
@@ -2728,12 +2728,8 @@ static void vxlan_xmit_one(struct sk_buff *skb, struct 
net_device *dev,
                        goto tx_error;
                } else if (err) {
                        if (info) {
-                               struct in_addr src, dst;
-
-                               src = remote_ip.sin.sin_addr;
-                               dst = local_ip.sin.sin_addr;
-                               info->key.u.ipv4.src = src.s_addr;
-                               info->key.u.ipv4.dst = dst.s_addr;
+                               info->key.u.ipv4.src = 
remote_ip.sin.sin_addr.s_addr;
+                               info->key.u.ipv4.dst = 
local_ip.sin.sin_addr.s_addr;
                        }
                        vxlan_encap_bypass(skb, vxlan, vxlan, vni, false);
                        dst_release(ndst);
@@ -2784,12 +2780,8 @@ static void vxlan_xmit_one(struct sk_buff *skb, struct 
net_device *dev,
                        goto tx_error;
                } else if (err) {
                        if (info) {
-                               struct in6_addr src, dst;
-
-                               src = remote_ip.sin6.sin6_addr;
-                               dst = local_ip.sin6.sin6_addr;
-                               info->key.u.ipv6.src = src;
-                               info->key.u.ipv6.dst = dst;
+                               info->key.u.ipv6.src = remote_ip.sin6.sin6_addr;
+                               info->key.u.ipv6.dst = local_ip.sin6.sin6_addr;
                        }
 
                        vxlan_encap_bypass(skb, vxlan, vxlan, vni, false);
-- 
2.17.1

Reply via email to