Hi Chris, rtsx_pci_write_register(pcr, FPDTL, OC_POWER_DOWN, OC_POWER_DOWN); This register operation saved power under 1mA, so if do not care the 1mA power we can have a patch to remove it, make compatible with NUC6 We tested others our card reader that remove it, we did not see any side effect
Hi Greg k-h, Do you have any comments? thanks Ricky > -----Original Message----- > From: Chris Clayton [mailto:chris2...@googlemail.com] > Sent: Monday, August 03, 2020 3:59 AM > To: LKML; 吳昊澄 Ricky; gre...@linuxfoundation.org; rdun...@infradead.org; > philqua...@gmail.com; Arnd Bergmann > Subject: Re: PATCH: rtsx_pci driver - don't disable the rts5229 card reader on > Intel NUC boxes > > Sorry, I should have said that the patch is against 5.7.12. It applies to > upstream, > but with offsets. > > On 02/08/2020 20:48, Chris Clayton wrote: > > bede03a579b3 introduced a bug which leaves the rts5229 PCI Express card > reader on my Intel NUC6CAYH box. > > > > The bug is in drivers/misc/cardreader/rtsx_pcr.c. A call to > > rtsx_pci_init_ocp() > was added to rtsx_pci_init_hw(). > > At the call point, pcr->ops->init_ocp is NULL and pcr->option.ocp_en is 0, > > so in > rtsx_pci_init_ocp() the cardreader > > gets disabled. > > > > I've avoided this by making excution code that results in the reader being > disabled conditional on the device > > not being an RTS5229. Of course, other rtsxxx card readers may also be > disabled by this bug. I don't have the > > knowledge to address that, so I'll leave to the driver maintainers. > > > > The patch to avoid the bug is attached. > > > > Fixes: bede03a579b3 ("misc: rtsx: Enable OCP for rts522a rts524a rts525a > rts5260") > > Link: https://marc.info/?l=linux-kernel&m=159105912832257 > > Link: https://bugzilla.kernel.org/show_bug.cgi?id=204003 > > Signed-off-by: Chris Clayton <chris2...@googlemail.com> > > > > bede03a579b3 introduced a bug which leaves the rts5229 PCI Express card > reader on my Intel NUC6CAYH box. > > > > The bug is in drivers/misc/cardreader/rtsx_pcr.c. A call to > > rtsx_pci_init_ocp() > was added to rtsx_pci_init_hw(). > > At the call point, pcr->ops->init_ocp is NULL and pcr->option.ocp_en is 0, > > so in > rtsx_pci_init_ocp() the cardreader > > gets disabled. > > > > I've avoided this by making excution code that results in the reader being > disabled conditional on the device > > not being an RTS5229. Of course, other rtsxxx card readers may also be > disabled by this bug. I don't have the > > knowledge to address that, so I'll leave to the driver maintainers. > > > > The patch to avoid the bug is attached. > > > > Chris > > > > ------Please consider the environment before printing this e-mail.
