On Thu, Jul 30, 2020 at 11:14:39PM +0000, Shaikh, Azhar wrote: > > > > -----Original Message----- > > From: Prashant Malani <pmal...@chromium.org> > > Sent: Thursday, July 30, 2020 4:05 PM > > To: Shaikh, Azhar <azhar.sha...@intel.com> > > Cc: ble...@chromium.org; enric.balle...@collabora.com; > > gro...@chromium.org; linux-kernel@vger.kernel.org; > > heikki.kroge...@linux.intel.com; Patel, Utkarsh H > > <utkarsh.h.pa...@intel.com>; Bowman, Casey G > > <casey.g.bow...@intel.com>; Mani, Rajmohan > > <rajmohan.m...@intel.com> > > Subject: Re: [PATCH v2 1/2] platform/chrome: cros_ec_typec: Send enum > > values to usb_role_switch_set_role() > > > > > > On Thu, Jul 30, 2020 at 11:02:28PM +0000, Shaikh, Azhar wrote: > > > Hi Prashant, > > > > > > > > > > > Please add the list of changes in each version after the "---" line. > > > > > > I have added those in the cover letter. > > > > > > It is good practice to add these to the individual change too, so that the > > reader doesn't have to go back to the cover letter to determine what has > > changed in each patch. > > So are you suggesting to move it from cover letter to individual patches? > But then isn't the same thing what cover letter is for?
No, I'm suggesting you keep it both places. Each patch should have a change log documenting what has changed in the various versions.
