Hi Roger, Thank you for the patch! Yet something to improve:
[auto build test ERROR on xen-tip/linux-next] [also build test ERROR on linus/master v5.8-rc7 next-20200727] [cannot apply to linux/master] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Roger-Pau-Monne/xen-balloon-fixes-for-memory-hotplug/20200727-171643 base: https://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git linux-next config: i386-randconfig-a001-20200727 (attached as .config) compiler: gcc-9 (Debian 9.3.0-14) 9.3.0 reproduce (this is a W=1 build): # save the attached .config to linux build tree make W=1 ARCH=i386 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <l...@intel.com> All errors (new ones prefixed by >>): In file included from include/xen/xen.h:61, from drivers/xen/xen-front-pgdir-shbuf.c:18: include/xen/balloon.h:8:8: error: redefinition of 'struct balloon_stats' 8 | struct balloon_stats { | ^~~~~~~~~~~~~ In file included from drivers/xen/xen-front-pgdir-shbuf.c:17: include/xen/balloon.h:8:8: note: originally defined here 8 | struct balloon_stats { | ^~~~~~~~~~~~~ In file included from include/xen/xen.h:61, from drivers/xen/xen-front-pgdir-shbuf.c:18: include/xen/balloon.h:23:29: error: conflicting types for 'balloon_stats' 23 | extern struct balloon_stats balloon_stats; | ^~~~~~~~~~~~~ In file included from drivers/xen/xen-front-pgdir-shbuf.c:17: include/xen/balloon.h:23:29: note: previous declaration of 'balloon_stats' was here 23 | extern struct balloon_stats balloon_stats; | ^~~~~~~~~~~~~ In file included from include/xen/xen.h:61, from drivers/xen/xen-front-pgdir-shbuf.c:18: >> include/xen/balloon.h:33:20: error: redefinition of 'xen_balloon_init' 33 | static inline void xen_balloon_init(void) | ^~~~~~~~~~~~~~~~ In file included from drivers/xen/xen-front-pgdir-shbuf.c:17: include/xen/balloon.h:33:20: note: previous definition of 'xen_balloon_init' was here 33 | static inline void xen_balloon_init(void) | ^~~~~~~~~~~~~~~~ -- In file included from drivers/xen/balloon.c:71: include/xen/balloon.h:8:8: error: redefinition of 'struct balloon_stats' 8 | struct balloon_stats { | ^~~~~~~~~~~~~ In file included from include/xen/xen.h:61, from drivers/xen/balloon.c:68: include/xen/balloon.h:8:8: note: originally defined here 8 | struct balloon_stats { | ^~~~~~~~~~~~~ In file included from drivers/xen/balloon.c:71: include/xen/balloon.h:23:29: error: conflicting types for 'balloon_stats' 23 | extern struct balloon_stats balloon_stats; | ^~~~~~~~~~~~~ In file included from include/xen/xen.h:61, from drivers/xen/balloon.c:68: include/xen/balloon.h:23:29: note: previous declaration of 'balloon_stats' was here 23 | extern struct balloon_stats balloon_stats; | ^~~~~~~~~~~~~ In file included from drivers/xen/balloon.c:71: >> include/xen/balloon.h:33:20: error: redefinition of 'xen_balloon_init' 33 | static inline void xen_balloon_init(void) | ^~~~~~~~~~~~~~~~ In file included from include/xen/xen.h:61, from drivers/xen/balloon.c:68: include/xen/balloon.h:33:20: note: previous definition of 'xen_balloon_init' was here 33 | static inline void xen_balloon_init(void) | ^~~~~~~~~~~~~~~~ drivers/xen/balloon.c:138:22: error: conflicting types for 'balloon_stats' 138 | struct balloon_stats balloon_stats; | ^~~~~~~~~~~~~ In file included from include/xen/xen.h:61, from drivers/xen/balloon.c:68: include/xen/balloon.h:23:29: note: previous declaration of 'balloon_stats' was here 23 | extern struct balloon_stats balloon_stats; | ^~~~~~~~~~~~~ In file included from include/linux/linkage.h:7, from include/linux/kernel.h:8, from arch/x86/include/asm/percpu.h:45, from arch/x86/include/asm/current.h:6, from include/linux/sched.h:12, from include/linux/ratelimit.h:6, from include/linux/dev_printk.h:16, from include/linux/device.h:15, from include/linux/node.h:18, from include/linux/cpu.h:17, from drivers/xen/balloon.c:41: drivers/xen/balloon.c:139:19: error: conflicting types for 'balloon_stats' 139 | EXPORT_SYMBOL_GPL(balloon_stats); | ^~~~~~~~~~~~~ include/linux/export.h:98:21: note: in definition of macro '___EXPORT_SYMBOL' 98 | extern typeof(sym) sym; \ | ^~~ include/linux/export.h:155:34: note: in expansion of macro '__EXPORT_SYMBOL' 155 | #define _EXPORT_SYMBOL(sym, sec) __EXPORT_SYMBOL(sym, sec, "") | ^~~~~~~~~~~~~~~ include/linux/export.h:159:33: note: in expansion of macro '_EXPORT_SYMBOL' 159 | #define EXPORT_SYMBOL_GPL(sym) _EXPORT_SYMBOL(sym, "_gpl") | ^~~~~~~~~~~~~~ drivers/xen/balloon.c:139:1: note: in expansion of macro 'EXPORT_SYMBOL_GPL' 139 | EXPORT_SYMBOL_GPL(balloon_stats); | ^~~~~~~~~~~~~~~~~ In file included from include/xen/xen.h:61, from drivers/xen/balloon.c:68: include/xen/balloon.h:23:29: note: previous declaration of 'balloon_stats' was here 23 | extern struct balloon_stats balloon_stats; | ^~~~~~~~~~~~~ -- In file included from include/xen/xen.h:61, from arch/x86/include/asm/xen/events.h:5, from include/xen/events.h:13, from drivers/xen/xenbus/xenbus_client.c:44: include/xen/balloon.h:8:8: error: redefinition of 'struct balloon_stats' 8 | struct balloon_stats { | ^~~~~~~~~~~~~ In file included from drivers/xen/xenbus/xenbus_client.c:43: include/xen/balloon.h:8:8: note: originally defined here 8 | struct balloon_stats { | ^~~~~~~~~~~~~ In file included from include/xen/xen.h:61, from arch/x86/include/asm/xen/events.h:5, from include/xen/events.h:13, from drivers/xen/xenbus/xenbus_client.c:44: include/xen/balloon.h:23:29: error: conflicting types for 'balloon_stats' 23 | extern struct balloon_stats balloon_stats; | ^~~~~~~~~~~~~ In file included from drivers/xen/xenbus/xenbus_client.c:43: include/xen/balloon.h:23:29: note: previous declaration of 'balloon_stats' was here 23 | extern struct balloon_stats balloon_stats; | ^~~~~~~~~~~~~ In file included from include/xen/xen.h:61, from arch/x86/include/asm/xen/events.h:5, from include/xen/events.h:13, from drivers/xen/xenbus/xenbus_client.c:44: >> include/xen/balloon.h:33:20: error: redefinition of 'xen_balloon_init' 33 | static inline void xen_balloon_init(void) | ^~~~~~~~~~~~~~~~ In file included from drivers/xen/xenbus/xenbus_client.c:43: include/xen/balloon.h:33:20: note: previous definition of 'xen_balloon_init' was here 33 | static inline void xen_balloon_init(void) | ^~~~~~~~~~~~~~~~ drivers/xen/xenbus/xenbus_client.c: In function 'xenbus_va_dev_error': drivers/xen/xenbus/xenbus_client.c:292:2: warning: function 'xenbus_va_dev_error' might be a candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format] 292 | vsnprintf(printf_buffer + len, PRINTF_BUFFER_SIZE - len, fmt, ap); | ^~~~~~~~~ vim +/xen_balloon_init +33 include/xen/balloon.h 803eb047a28d23 Daniel De Graaf 2011-03-14 22 803eb047a28d23 Daniel De Graaf 2011-03-14 @23 extern struct balloon_stats balloon_stats; 803eb047a28d23 Daniel De Graaf 2011-03-14 24 803eb047a28d23 Daniel De Graaf 2011-03-14 25 void balloon_set_new_target(unsigned long target); b6f3067985f12d Konrad Rzeszutek Wilk 2011-03-15 26 81b286e0f1fe52 David Vrabel 2015-06-25 27 int alloc_xenballooned_pages(int nr_pages, struct page **pages); b6f3067985f12d Konrad Rzeszutek Wilk 2011-03-15 28 void free_xenballooned_pages(int nr_pages, struct page **pages); a50777c791031d Dan Magenheimer 2011-07-08 29 96edd61dcf4436 Juergen Gross 2017-07-10 30 #ifdef CONFIG_XEN_BALLOON 96edd61dcf4436 Juergen Gross 2017-07-10 31 void xen_balloon_init(void); 96edd61dcf4436 Juergen Gross 2017-07-10 32 #else 96edd61dcf4436 Juergen Gross 2017-07-10 @33 static inline void xen_balloon_init(void) --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip