Em Fri, Jul 17, 2020 at 10:01:33AM +0300, Alexey Budankov escreveu: > > Implement functions of initialization, finalization and processing > of control command messages coming from control file descriptors. > Allocate control file descriptor as descriptor at struct pollfd > object of evsel_list for atomic poll() operation. > > Signed-off-by: Alexey Budankov <alexey.budan...@linux.intel.com> > Acked-by: Jiri Olsa <jo...@redhat.com> > Acked-by: Namhyung Kim <namhy...@kernel.org>
I'm applying locally for testing, but can you answer what is the reason for that newline in the CMD_ACK_TAG? I tried looking at previous discussion but couldn't quickly find any reasoning for that - Arnaldo > +++ b/tools/perf/util/evlist.h > @@ -359,4 +359,22 @@ void perf_evlist__force_leader(struct evlist *evlist); > struct evsel *perf_evlist__reset_weak_group(struct evlist *evlist, > struct evsel *evsel, > bool close); > +#define EVLIST_CTL_CMD_ENABLE_TAG "enable" > +#define EVLIST_CTL_CMD_DISABLE_TAG "disable" > +#define EVLIST_CTL_CMD_ACK_TAG "ack\n" What for? That '\n'?
