Hi David > -----Original Message----- > From: David Hildenbrand <da...@redhat.com> > Sent: Thursday, July 9, 2020 5:19 PM > To: Mike Rapoport <r...@linux.ibm.com>; Matthew Wilcox > <wi...@infradead.org> > Cc: Justin He <justin...@arm.com>; Catalin Marinas > <catalin.mari...@arm.com>; Will Deacon <w...@kernel.org>; Tony Luck > <tony.l...@intel.com>; Fenghua Yu <fenghua...@intel.com>; Yoshinori Sato > <ys...@users.sourceforge.jp>; Rich Felker <dal...@libc.org>; Dave Hansen > <dave.han...@linux.intel.com>; Andy Lutomirski <l...@kernel.org>; Peter > Zijlstra <pet...@infradead.org>; Thomas Gleixner <t...@linutronix.de>; > Ingo Molnar <mi...@redhat.com>; Borislav Petkov <b...@alien8.de>; > x...@kernel.org; H. Peter Anvin <h...@zytor.com>; Dan Williams > <dan.j.willi...@intel.com>; Vishal Verma <vishal.l.ve...@intel.com>; Dave > Jiang <dave.ji...@intel.com>; Andrew Morton <a...@linux-foundation.org>; > Baoquan He <b...@redhat.com>; Chuhong Yuan <hsleste...@gmail.com>; Logan > Gunthorpe <log...@deltatee.com>; Masahiro Yamada <masahi...@kernel.org>; > Michal Hocko <mho...@suse.com>; linux-arm-ker...@lists.infradead.org; > linux-kernel@vger.kernel.org; linux-i...@vger.kernel.org; linux- > s...@vger.kernel.org; linux-nvd...@lists.01.org; linux...@kvack.org; > Jonathan Cameron <jonathan.came...@huawei.com>; Kaly Xin <kaly....@arm.com> > Subject: Re: [PATCH v3 4/6] mm: don't export memory_add_physaddr_to_nid in > arch specific directory > > On 09.07.20 11:18, Mike Rapoport wrote: > > On Thu, Jul 09, 2020 at 03:11:04AM +0100, Matthew Wilcox wrote: > >> On Thu, Jul 09, 2020 at 10:06:27AM +0800, Jia He wrote: > >>> After a general version of __weak memory_add_physaddr_to_nid > implemented > >>> and exported , it is no use exporting twice in arch directory even if > >>> e,g, ia64/x86 have their specific version. > >>> > >>> This is to suppress the modpost warning: > >>> WARNING: modpost: vmlinux: 'memory_add_physaddr_to_nid' exported twice. > >>> Previous export was in vmlinux > >> > >> It's bad form to introduce a warning and then send a follow-up patch to > >> fix the warning. Just fold this patch into patch 1/6. > > > > Moreover, I think that patches 1-4 can be merged into one. > > > > +1
Okay, will update, thanks -- Cheers, Justin (Jia He)
