On Thu, 02 Jul 2020, Gene Chen wrote: > Lee Jones <lee.jo...@linaro.org> 於 2020年7月1日 週三 下午3:16寫道： > > > > On Fri, 19 Jun 2020, Gene Chen wrote: > > > > > From: Gene Chen <gene_c...@richtek.com> > > > > > > imlement i2c R/W with CRC when access sub-device PMIC and LDO part > > > > Please use proper grammar, including capital letters at the start of > > the sentence and for abbreviations such as "I2C" and full stops. > > > > Also this doesn't make sense to me. Please elaborate. > > > > ACK > > > > Signed-off-by: Gene Chen <gene_c...@richtek.com> > > > --- > > > drivers/mfd/Kconfig | 1 + > > > drivers/mfd/mt6360-core.c | 541 > > > +++++++++++++++++++++++++++++---------------- > > > > This patch is doing way too much wacky stuff all at once, making it > > very difficult to review. Please break it up into functional pieces > > and submit as separate logical patches (in a set of course). > > > > If I understand correctly, I need to separate patch[2/4] but not > entire mt6362-core.c into several patches.
Yes please. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
