On Wed, Jun 24, 2020 at 3:15 PM Anson Huang <anson.hu...@nxp.com> wrote: > > Hi, Franck/Arnd > > > Subject: RE: [PATCH] firmware: imx: Move i.MX SCU soc driver into SCU > > firmware driver > > > > Hello, > > > > The move of folder is a good idea however I do not feel adding the code of > > soc-imx-scu.c to imx-scu.c is the best. > > Until now imx-scu.c was focused on exchanging the RPC and init the IRQ. > > Why not have soc-imx-scu.c copied to imx-scu-soc.c (change filename) to > > have a pattern similar to imx-scu-irq? And keep the imx_scu_soc_init into > > imx-scu.c. > > > Sound like making sense to me, it can make the code architecture more clear. > > What do you think?
Yes, I agree that is a good idea. Arnd