> -----Original Message----- > From: Shevchenko, Andriy <[email protected]> > Sent: Wednesday, June 17, 2020 10:01 PM > To: Wan Mohamad, Wan Ahmad Zainie > <[email protected]> > Cc: [email protected]; [email protected]; [email protected]; linux- > [email protected]; [email protected]; Hunter, Adrian > <[email protected]> > Subject: Re: [RESEND v5 2/2] phy: intel: Add Keem Bay eMMC PHY support > > On Wed, Jun 17, 2020 at 07:32:52AM +0800, Wan Ahmad Zainie wrote: > > Add support for eMMC PHY on Intel Keem Bay SoC. > > ... > > > + ret = regmap_read_poll_timeout(priv->syscfg, PHY_STAT, > > + dllrdy, IS_DLLRDY(dllrdy), > > + 0, 50 * USEC_PER_MSEC); > > + if (ret) { > > + dev_err(&phy->dev, "dllrdy failed, ret=%d\n", ret); > > + return ret; > > + } > > + > > + return ret; > > +} > > This has no changes. > > Are you sure the version is correct? Ah. Sorry Andy. I misunderstood your earlier review comment. You mean return inside the last if(...) should be discarded. Kishon, should I send another version, or is it acceptable? > > -- > With Best Regards, > Andy Shevchenko >
RE: [RESEND v5 2/2] phy: intel: Add Keem Bay eMMC PHY support
Wan Mohamad, Wan Ahmad Zainie Thu, 18 Jun 2020 20:18:22 -0700
