Hi! > > > - reg_val = pdata->pass_mode; > > > + reg_val = (u32)pdata->pass_mode; > > > > Is this cast needed? I don't think there should be warning from going > > from an enumerated type to unsigned int. > > This cast is not needed for warnings, I added it for consistency because > it seemed odd to cast only four of the five enums. I can remove if though > if you think it's clearer without the cast. > > There may also be a different solution in completely removing the > lm355x_chip_init() function, as it was added at a time when we > were converting the last board files into devicetree, and there has > never been a board file defining lm355x_platform_data. > > There is unfortunately no DT support either in it, so I assume we > could just remove the driver completely, or change it to use a > DT binding similar to > Documentation/devicetree/bindings/leds/leds-lm36*.txt > > LED maintainers, any opinions on this?
I believe it is too soon to remove the driver; even if new user will
have to add DT support, that is less work than starting from scratch.
I guess I'll just apply your patch to squelch the warnings.
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures)
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
signature.asc
Description: PGP signature
