Alexey Dobriyan wrote: > ["if (!x & y)" patch from [EMAIL PROTECTED] > ["if (!x & y)" patch from [EMAIL PROTECTED] > ["if (!x & y)" patches from [EMAIL PROTECTED] > > While we're at it, below is somewhat ugly sparse patch for detecting > "&& 0x" typos.
Excellent idea! I think it applies to || as well. I'll most likely add a -Wboolean-logic-on-bit-constant to turn this warning on. Any reason why this wouldn't apply to octal constants or to GCC's new binary constants? I can trivially modify this patch to handle those as well, just by dropping the check for an 'x' or 'X', and renaming the flag. As far as patch beauty goes, I think this patch looks just fine. - Josh Triplett - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
