On Thu, Apr 30, 2020 at 9:50 PM Maninder Singh <maninder...@samsung.com> wrote:
>
> if objdump has below entries;
> c01ed608 <X>:
> c01ed614: e24ddff7 sub sp, sp, #120 ; 0x78
>
> c01f0d50 <Y>:
> c01f0d50: e24dd094 sub sp, sp, #140 ; 0x8c
>
> scripts fails to read stack usage.
> so making regex $re for ARM similar to aarch64
>
> Signed-off-by: Vaneet Narang <v.nar...@samsung.com>
> Signed-off-by: Maninder Singh <maninder...@samsung.com>
This looks good to me, and it is a bug fix.
Just a question about the SOB.
Maninder Singh is the author and also the submitter, right?
What does "Signed-off-by: Vaneet Narang <v.nar...@samsung.com>" mean?
Co-developed-by or something else?
> ---
> scripts/checkstack.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/checkstack.pl b/scripts/checkstack.pl
> index b292ef4..e80de70 100755
> --- a/scripts/checkstack.pl
> +++ b/scripts/checkstack.pl
> @@ -60,7 +60,7 @@ my (@stack, $re, $dre, $sub, $x, $xs, $funcre, $min_stack);
> $dre = qr/^.*sub.*sp, sp, #(0x$x{1,8})/o;
> } elsif ($arch eq 'arm') {
> #c0008ffc: e24dd064 sub sp, sp, #100 ; 0x64
> - $re = qr/.*sub.*sp, sp, #(([0-9]{2}|[3-9])[0-9]{2})/o;
> + $re = qr/.*sub.*sp, sp, #([0-9]{1,4})/o;
> $sub = \&arm_push_handling;
> } elsif ($arch =~ /^x86(_64)?$/ || $arch =~ /^i[3456]86$/) {
> #c0105234: 81 ec ac 05 00 00 sub $0x5ac,%esp
> --
> 1.9.1
>
--
Best Regards
Masahiro Yamada
